feat: use CoinSelection class from coinlib for coin selection #1316
Draft
Cyrix126 wants to merge 2 commits intocypherstack:stagingfrom
Draft
feat: use CoinSelection class from coinlib for coin selection #1316Cyrix126 wants to merge 2 commits intocypherstack:stagingfrom
Cyrix126 wants to merge 2 commits intocypherstack:stagingfrom
Conversation
Replace the legacy FIFO algorithm used so far, except for cases that can not be treated by new coin selection algorithms (mweb input, override fee, send all, coin control)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses coinlib lib to make the coin selection instead of the current FIFO implemented, except for cases that are not supported (mweb inputs, override of fee).
The pubsec.yaml template is modified to fetch the coinlib repository to my fork that now includes an implementation in dart of the BnB algo directly in coinlib.
The buildTransaction standard input to coinlib input logic has been abstracted to a new function since the coinlib coin selection function also need coinlib inputs.